-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename NetStandard projects #136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keen.NetStandard -> Keen - Keen.NetStandard.Test -> Keen.Test
baumatron
approved these changes
Nov 13, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Merging even though the MacOS CI job hasn't finished...changes since last successful MacOS build are comment-only. If there's an issue, I'll deal with the merge of this and PR #135 directly in |
This was referenced Nov 14, 2017
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
Keen.NetStandard
->Keen
and also drop a level in the nested namespace hierarchy, so now instead ofKeen.Core
,Keen.Core.Query
,Keen.NET
,Keen.Core.EventCache
etc....everything is in a namespace once nested fromKeen
, soKeen.Core
,Keen.Query
,Keen.Datasets
and so forth are all siblings. One could argue some stuff needs to move up into justKeen
but we can do that later if needed.Mostly namespace renames, but again there are changes in project files/.sln/CI configs and scripts to reference the right assets and such.