Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename NetStandard projects #136

Merged
merged 7 commits into from
Nov 13, 2017
Merged

Rename NetStandard projects #136

merged 7 commits into from
Nov 13, 2017

Conversation

masojus
Copy link
Contributor

@masojus masojus commented Nov 11, 2017

Rename Keen.NetStandard->Keen and also drop a level in the nested namespace hierarchy, so now instead of Keen.Core, Keen.Core.Query, Keen.NET, Keen.Core.EventCache etc....everything is in a namespace once nested from Keen, so Keen.Core, Keen.Query, Keen.Datasets and so forth are all siblings. One could argue some stuff needs to move up into just Keen but we can do that later if needed.

Mostly namespace renames, but again there are changes in project files/.sln/CI configs and scripts to reference the right assets and such.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.802% when pulling b92b201 on jm_RenameNetStandardProj into 639d870 on jm_OnlyNetStandardProj.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.802% when pulling 50e9740 on jm_RenameNetStandardProj into 1980af1 on jm_OnlyNetStandardProj.

Copy link
Contributor

@baumatron baumatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.802% when pulling 3915360 on jm_RenameNetStandardProj into 16046c9 on jm_OnlyNetStandardProj.

@masojus masojus changed the base branch from jm_OnlyNetStandardProj to master November 13, 2017 21:50
@masojus
Copy link
Contributor Author

masojus commented Nov 13, 2017

Merging even though the MacOS CI job hasn't finished...changes since last successful MacOS build are comment-only. If there's an issue, I'll deal with the merge of this and PR #135 directly in master, but it'd unlikely.

@masojus masojus merged commit 55b8985 into master Nov 13, 2017
@masojus masojus deleted the jm_RenameNetStandardProj branch November 16, 2017 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants